Skip to content

Merge master in release #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions DevelopmentWorkflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@

<!-- TOC depthFrom:2 -->

- [Running locally](#running-locally)
- [Development Workflow](#development-workflow)
- [Running locally](#running-locally)
- [Prerequisites](#prerequisites)
- [Install dependencies](#install-dependencies)
- [Run the sample application (ng-sample)](#run-the-sample-application-ng-sample)
- [Running the tests](#running-the-tests)
- [Testing locally by running e2e tests](#testing-locally-by-running-e2e-tests)
- [Developer workflow](#developer-workflow)
- [Clone repository](#clone-repository)
- [Install dependencies of the compatibility package (nativescript-angular)](#install-dependencies-of-the-compatibility-package-nativescript-angular)
- [Install dependencies of the scoped package (@nativescript/angular)](#install-dependencies-of-the-scoped-package-nativescriptangular)
- [Run some of the e2e applications e.g. router-tab-view](#run-some-of-the-e2e-applications-eg-router-tab-view)
- [Running the tests](#running-the-tests)
- [Testing locally by running e2e tests](#testing-locally-by-running-e2e-tests)

<!-- /TOC -->

Expand All @@ -27,18 +29,25 @@ $ git clone [email protected]:NativeScript/nativescript-angular.git
$ cd nativescript-angular
```

### Install dependencies
### Install dependencies of the compatibility package (nativescript-angular)

```
$ cd nativescript-angular
$ npm install
```

### Run the sample application (ng-sample)
### Install dependencies of the scoped package (@nativescript/angular)

```
$ cd nativescript-angular-package
$ npm install
```

### Run some of the e2e applications e.g. router-tab-view

Install NPM packages (use the local copy of `nativescript-angular`):
```
$ cd ng-sample
$ cd e2e/router-tab-view
$ npm install
```

Expand All @@ -49,6 +58,8 @@ $ tns run android
$ tns run ios
```

Make changes to `nativescript-angular` (in `./nativescript-angular-package` folder) or `@nativescript/angular` (in `./nativescript-angular` folder) and see them applied in the running app.

## Running the tests

Install the NPM dependencies (use the local copy of `nativescript-angular`):
Expand Down Expand Up @@ -95,9 +106,4 @@ NOTE: The steps below describe how to run `renderer` tests, but the same approac
``` bash
npm run e2e -- --runType capabilityName
```

## Developer workflow

1. Open the `nativescript-angular` folder and start a typescript watcher in it `tsc -w`.
2. Make changes to the `test`, `ng-sample`, `e2e` app projects or in `nativescript-angular` folder.
3. Run the `tests`, `ng-sample` or `e2e` apps as shown above.

13 changes: 7 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@ This repository contains the code for integration of NativeScript with Angular.

<!-- TOC depthFrom:2 -->

- [Watch the video explaining Angular and NativeScript](#watch-the-video-explaining-angular-and-nativescript)
- [Explore the examples](#explore-the-examples)
- [Contribute](#contribute)
- [Known issues](#known-issues)
- [Get Help](#get-help)
- [NativeScript Angular](#nativescript-angular)
- [Watch the video explaining Angular and NativeScript](#watch-the-video-explaining-angular-and-nativescript)
- [Explore the examples](#explore-the-examples)
- [Contribute](#contribute)
- [Known issues](#known-issues)
- [Get Help](#get-help)

<!-- /TOC -->

Expand All @@ -22,7 +23,7 @@ This repository contains the code for integration of NativeScript with Angular.

## Explore the examples

The `ng-sample` app is meant for testing stuff while developing the renderer code, and isn't the best example out there. You can take a look at these sample apps that use the published builds from npm:
The `e2e` apps are meant for testing stuff. You can take a look at these additional sample apps that use the published builds from npm:

* [Hello world starter](https://github.com/NativeScript/nativescript-app-templates/tree/master/packages/template-hello-world-ng)
* [Master-detail template](https://github.com/NativeScript/nativescript-app-templates/tree/master/packages/template-master-detail-ng)
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion nativescript-angular-package/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nativescript-angular",
"version": "8.20.3",
"version": "8.20.4",
"description": "An Angular renderer that lets you build mobile apps with NativeScript.",
"homepage": "https://www.nativescript.org/",
"bugs": "https://github.com/NativeScript/nativescript-angular/issues",
Expand Down
2 changes: 1 addition & 1 deletion nativescript-angular/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nativescript/angular",
"version": "8.20.3",
"version": "8.20.4",
"description": "An Angular renderer that lets you build mobile apps with NativeScript.",
"homepage": "https://www.nativescript.org/",
"bugs": "https://github.com/NativeScript/nativescript-angular/issues",
Expand Down
58 changes: 0 additions & 58 deletions ng-sample/.vscode/launch.json

This file was deleted.

10 changes: 0 additions & 10 deletions ng-sample/.vscode/settings.json

This file was deleted.

23 changes: 0 additions & 23 deletions ng-sample/LICENSE

This file was deleted.

8 changes: 0 additions & 8 deletions ng-sample/README.md

This file was deleted.

40 changes: 0 additions & 40 deletions ng-sample/app/App_Resources/Android/AndroidManifest.xml

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
6 changes: 0 additions & 6 deletions ng-sample/app/App_Resources/iOS/Assets.xcassets/Contents.json

This file was deleted.

Loading