chore: fix date test when GMT is negative #2063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
This test fails on negative timezones because
2010-03-17
is interpreted as UTC, while the compared date is created in the local timezone. The formatted date then becomes2010-03-16
because the object is2010-03-16T23:00:00 GMT-0100
for example.https://stackoverflow.com/questions/22959453/javascript-date-using-forward-slashes-vs-hyphens
What is the new behavior?
This test no longer fails