Skip to content

fix: make FileSystemResourceLoader sync #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2019
Merged

fix: make FileSystemResourceLoader sync #2040

merged 1 commit into from
Oct 28, 2019

Conversation

vakrilov
Copy link
Contributor

PR Checklist

What is the current behavior?

Since NativeScript/NativeScript#7671 File. readText() no longer resolves synchronously. This causes a Bootstrap promise didn't resolve error on startup for playground projects.

What is the new behavior?

Use readTextSync() method in the FileSystemResourceLoader so that resources are resolved synchronously again.

@cla-bot cla-bot bot added the cla: yes label Oct 25, 2019
@vakrilov
Copy link
Contributor Author

test

@elena-p elena-p merged commit f1f4faa into release Oct 28, 2019
@elena-p elena-p deleted the sync-resouce-loader branch October 28, 2019 09:20
tbozhikov pushed a commit that referenced this pull request Oct 28, 2019
@tbozhikov
fix: make FileSystemResourceLoader sync again (#2040)
72591e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtrifonov vtrifonov vtrifonov approved these changes

@VladimirAmiorkov VladimirAmiorkov VladimirAmiorkov approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vakrilov @vtrifonov @VladimirAmiorkov @elena-p