Skip to content

chore: ng-sample build fail #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion nativescript-angular/tsconfig.typedoc.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
"./router/private-imports",
"./schema-registry.ts",
"./http-client/index.ts",
"./http/index.ts",
"./router/index.ts",
""

Expand Down
5 changes: 0 additions & 5 deletions ng-sample/app/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { DOCUMENT } from "@angular/common";
import { Router } from "@angular/router";
import { NativeScriptRouterModule } from "nativescript-angular/router";
import { NativeScriptFormsModule } from "nativescript-angular/forms";
import { NativeScriptHttpModule } from "nativescript-angular/http";
import { NativeScriptHttpClientModule } from "nativescript-angular/http-client";

import {
Expand Down Expand Up @@ -42,7 +41,6 @@ import { ListTest } from "./examples/list/list-test";
import { ListTemplateSelectorTest } from "./examples/list/template-selector";
import { ListTestAsync, ListTestFilterAsync } from "./examples/list/list-test-async";
import { ImageTest } from "./examples/image/image-test";
import { HttpTest } from "./examples/http/http-test";
import { HttpClientTest } from "./examples/http-client/http-client-test";
import { ActionBarTest } from "./examples/action-bar/action-bar-test";
import { PlatfromDirectivesTest } from "./examples/platform-directives/platform-directives-test";
Expand Down Expand Up @@ -73,14 +71,12 @@ import { AnimationStatesMultiTest } from "./examples/animation/animation-states-
imports: [
NativeScriptModule,
NativeScriptFormsModule,
NativeScriptHttpModule,
NativeScriptHttpClientModule,
NativeScriptRouterModule,
],
exports: [
NativeScriptModule,
NativeScriptFormsModule,
NativeScriptHttpModule,
NativeScriptHttpClientModule,
NativeScriptRouterModule,
],
Expand Down Expand Up @@ -146,7 +142,6 @@ class MyErrorHandler implements ErrorHandler {
platformNativeScriptDynamic().bootstrapModule(makeExampleModule(ListTestAsync));
// platformNativeScriptDynamic().bootstrapModule(makeExampleModule(ImageTest));
// platformNativeScriptDynamic().bootstrapModule(makeExampleModule(ModalTest));
// platformNativeScriptDynamic().bootstrapModule(makeExampleModule(HttpTest));
// platformNativeScriptDynamic().bootstrapModule(makeExampleModule(HttpClientTest));
// platformNativeScriptDynamic().bootstrapModule(makeExampleModule(PlatfromDirectivesTest));
// platformNativeScriptDynamic().bootstrapModule(makeExampleModule(ActionBarTest));
Expand Down
2 changes: 1 addition & 1 deletion ng-sample/app/examples/http-client/http-client-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class HttpClientTest {
}

public loadLocal() {
this.http.get<DataResults<LocalData>>("~/examples/http/data.json")
this.http.get<DataResults<LocalData>>("~/examples/http-client/data.json")
.subscribe((response) => {
let user = response.results[0];
this.onSuccess(user.title, user.description);
Expand Down
8 changes: 0 additions & 8 deletions ng-sample/app/examples/http/data.json

This file was deleted.

56 changes: 0 additions & 56 deletions ng-sample/app/examples/http/http-test.ts

This file was deleted.

4 changes: 2 additions & 2 deletions ng-sample/app/examples/list/list-test-async.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { combineLatest } from "rxjs/operators";

@Component({
selector: "list-test-async",
styleUrls: ["examples/list/styles.css"],
styleUrls: ["./styles.css"],
providers: [DataService],
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
Expand Down Expand Up @@ -58,7 +58,7 @@ export class ListTestAsync {

@Component({
selector: "list-test-async-filter",
styleUrls: ["examples/list/styles.css"],
styleUrls: ["./styles.css"],
providers: [DataService],
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
Expand Down
4 changes: 2 additions & 2 deletions ng-sample/app/examples/list/list-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class DataItem {

@Component({
selector: "item-component",
styleUrls: ["examples/list/styles.css"],
styleUrls: ["./styles.css"],
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<StackLayout [class.odd]="odd" [class.even]="even">
Expand All @@ -35,7 +35,7 @@ export class ItemComponent implements AfterViewChecked, DoCheck {

@Component({
selector: "list-test",
styleUrls: ["examples/list/styles.css"],
styleUrls: ["./styles.css"],
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<GridLayout rows="auto * auto">
Expand Down
6 changes: 3 additions & 3 deletions ng-sample/app/examples/list/template-selector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class DataItem {

@Component({
selector: "item-component",
styleUrls: ["examples/list/styles.css"],
styleUrls: ["./styles.css"],
changeDetection: ChangeDetectionStrategy.OnPush,
template: `<Label class="item" [text]='"[" + data.id +"]" + data.name'></Label>`
})
Expand All @@ -21,7 +21,7 @@ export class ItemComponent implements DoCheck {

@Component({
selector: "header-component",
styleUrls: ["examples/list/styles.css"],
styleUrls: ["./styles.css"],
changeDetection: ChangeDetectionStrategy.OnPush,
template: `<Label class="header" [text]='data.name'></Label>`
})
Expand All @@ -32,7 +32,7 @@ export class HeaderComponent implements DoCheck {

@Component({
selector: "list-test",
styleUrls: ["examples/list/styles.css"],
styleUrls: ["./styles.css"],
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<GridLayout rows="auto * auto">
Expand Down
6 changes: 3 additions & 3 deletions ng-sample/app/examples/router/page-router-outlet-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { map } from "rxjs/operators";

@Component({
selector: "first",
styleUrls: ["examples/router/styles.css"],
styleUrls: ["./styles.css"],
template: `
<StackLayout>
<Label text="First component" class="title"></Label>
Expand All @@ -34,7 +34,7 @@ export class FirstComponent implements OnInit, OnDestroy {

@Component({
selector: "second",
styleUrls: ["examples/router/styles.css"],
styleUrls: ["./styles.css"],
template: `
<StackLayout>
<Label [text]="'Second component: ' + (id | async)" class="title"></Label>
Expand Down Expand Up @@ -68,7 +68,7 @@ export class SecondComponent implements OnInit, OnDestroy {

@Component({
selector: "third",
styleUrls: ["examples/router/styles.css"],
styleUrls: ["./styles.css"],
template: `
<StackLayout>
<Label [text]="'Third component: ' + (id | async)" class="title"></Label>
Expand Down
4 changes: 3 additions & 1 deletion ng-sample/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,14 @@
"zone.js": "^0.9.1"
},
"devDependencies": {
"@angular/compiler-cli": "~8.2.0",
"@ngtools/webpack": "~8.2.0",
"babel-traverse": "6.9.0",
"babel-types": "6.10.0",
"babylon": "6.8.1",
"filewalker": "0.1.2",
"lazy": "1.0.11",
"nativescript-dev-typescript": "next",
"nativescript-dev-webpack": "~1.0.1",
"shelljs": "^0.7.0",
"tslint": "^4.5.1",
"typescript": "~3.5.3"
Expand Down
9 changes: 9 additions & 0 deletions ng-sample/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,19 @@
"*": [
"./node_modules/tns-core-modules/*",
"./node_modules/*"
],
"~/*": [
"app/*"
]
},
},
"include": [
"../nativescript-angular",
"**/*"
],
"exclude": [
"../nativescript-angular/node_modules",
"../nativescript-angular/**/*.d.ts",
"node_modules",
"platforms"
]
Expand Down