Skip to content

feat: migrate to Angular 8 #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 29, 2019
Merged

feat: migrate to Angular 8 #1831

merged 11 commits into from
May 29, 2019

Conversation

VladimirAmiorkov
Copy link
Contributor

@VladimirAmiorkov VladimirAmiorkov commented May 20, 2019 •
edited
Loading

Testing the current RC of Angular with nativeScript-angular

Fixes: #1833

BREAKING CHANGES:

  • In Angular version 8, it's required that all @ViewChild and @ContentChild queries have a 'static' flag specifying whether the query is 'static' or 'dynamic'. More details about this change can be found here.

Migration steps:

Anywhere you previously had @ViewChild with a single param you now have to provide a second param with a static property set to either true or false

Previous code:

import { ElementRef } from "@angular/core";

@ViewChild("myElement") myElement: ElementRef;

Migrated code:

import { ElementRef } from "@angular/core";

@ViewChild("myElement", { static: false }) myElement: ElementRef;

VladimirAmiorkov added 2 commits May 20, 2019 14:07
@VladimirAmiorkov VladimirAmiorkov self-assigned this May 20, 2019
@cla-bot cla-bot bot added the cla: yes label May 20, 2019
@DimitarTachev DimitarTachev mentioned this pull request May 21, 2019
Merged
5 tasks
@NativeScript NativeScript deleted a comment from DimitarTachev May 21, 2019
@SvetoslavTsenov
Copy link
Contributor

test branch_nativescript_dev_webpack#feature/angular8 sdk_ng sample_Groceries

@SvetoslavTsenov
Copy link
Contributor

test branch_nativescript_dev_webpack#feature/angular8 sdk_ng sample_Groceries

@SvetoslavTsenov
Copy link
Contributor

test --ignore api23 ios11 branch_nativescript_dev_webpack#feature/angular8 sdk_ng#amiorkov/angular8-rc sample_Groceries#amiorkov/angular8-rc

@SvetoslavTsenov
Copy link
Contributor

test --ignore api23 ios11 branch_nativescript_dev_webpack#feature/angular8 sdk_ng#amiorkov/angular8-rc groceries#amiorkov/angular8-rc

@VladimirAmiorkov
Copy link
Contributor Author

test --ignore api23 ios11 branch_nativescript_dev_webpack#feature/angular8 sdk_ng#amiorkov/angular8-rc groceries#amiorkov/angular8-rc

2 similar comments
@VladimirAmiorkov
Copy link
Contributor Author

test --ignore api23 ios11 branch_nativescript_dev_webpack#feature/angular8 sdk_ng#amiorkov/angular8-rc groceries#amiorkov/angular8-rc

@VladimirAmiorkov
Copy link
Contributor Author

test --ignore api23 ios11 branch_nativescript_dev_webpack#feature/angular8 sdk_ng#amiorkov/angular8-rc groceries#amiorkov/angular8-rc

@VladimirAmiorkov
Copy link
Contributor Author

test --ignore api23 ios11 branch_nativescript_dev_webpack#feature/angular8 sdk_ng#amiorkov/angular8-rc groceries#amiorkov/angular8-rc

@VladimirAmiorkov
Copy link
Contributor Author

test --ignore

vakrilov
vakrilov previously approved these changes May 29, 2019
View reviewed changes
@VladimirAmiorkov
Copy link
Contributor Author

test --ignore

@SvetoslavTsenov SvetoslavTsenov merged commit b45916c into master May 29, 2019
@VladimirAmiorkov VladimirAmiorkov deleted the amiorkov/angular8-rc branch May 29, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vakrilov vakrilov vakrilov approved these changes

Assignees

@VladimirAmiorkov VladimirAmiorkov

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular 8 support
3 participants
@VladimirAmiorkov @SvetoslavTsenov @vakrilov