Skip to content

release: cut the 7.2.4 release #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 51 commits into from
Closed

release: cut the 7.2.4 release #1790

wants to merge 51 commits into from

Conversation

SvetoslavTsenov
Copy link
Contributor

No description provided.

SvetoslavTsenov and others added 30 commits February 8, 2019 18:16
…on-7.3.0

chore: bump package versino tp 7.3.0
* fix(router): routing services should be provided in forRoot only

* refactor: remove logs

* refactor: use single return statment in forRoot/Child
fix(location-strategy): crash on going back with router-outlet after closing modal
If exit event was triggered twice we would try to destroy an already
destroy module ref.
The usage of short imports, e.g, `import * as Page from "ui/page"`
instead of `import * as Page from "tns-core-modules/ui/page"` is
*deprecated* since {N} 5.2.
Don't destroy the angular module on restart
SvetoslavTsenov and others added 21 commits March 14, 2019 20:51
feat(modal): expose current/future core options via ModalDialogParams
chore(list-view): rename the new options API and change its type
Update modal to allow use of ios presentationStyle
refactor: minor changes after review
fix(NativeScriptPlatformRef): Destroy lastModuleRef on exitEvent
…s-resolution

chore(tsconfig): remove path resolution for short imports (`ui/page`)
### Bug Fixes

* **router:** routing services should be provided in forRoot only ([#1729](https://github.com/NativeScript/nativescript-angular/issues/1729)) ([0f6a975](https://github.com/NativeScript/nativescript-angular/commit/0f6a975))
* on destroy remove the lastBootstrappedModule ([5e13263](https://github.com/NativeScript/nativescript-angular/commit/5e13263))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and the next 3 commits are all part of one PR - #1728 could we link only this PR and/or the issue it is related to - #923 instead of listing all commits

@ghost ghost removed the in progress label Apr 23, 2019
@SvetoslavTsenov SvetoslavTsenov deleted the release-7.2.4 branch April 23, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants