Skip to content

fix: Router tracing does not work with webpack #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2019
Merged

fix: Router tracing does not work with webpack #1723

merged 1 commit into from
Feb 9, 2019

Conversation

vakrilov
Copy link
Contributor

@vakrilov vakrilov commented Feb 9, 2019

Always register the NativeScriptDomAdapter.
It is used for console.logging when router tracing is enabled.

resolves #650 even when bundling application with webpack.

@ghost ghost assigned vakrilov Feb 9, 2019
@ghost ghost added the in progress label Feb 9, 2019
@vakrilov
Copy link
Contributor Author

vakrilov commented Feb 9, 2019

test package_version#rc

@SvetoslavTsenov SvetoslavTsenov merged commit 3467add into release Feb 9, 2019
@ghost ghost removed the in progress label Feb 9, 2019
@SvetoslavTsenov SvetoslavTsenov deleted the router-tracing-release branch February 9, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvetoslavTsenov SvetoslavTsenov SvetoslavTsenov approved these changes

Assignees

@vakrilov vakrilov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vakrilov @SvetoslavTsenov