Skip to content

fix: Router tracing does not work with webpack #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: Router tracing does not work with webpack #1720

wants to merge 2 commits into from

Conversation

vakrilov
Copy link
Contributor

@vakrilov vakrilov commented Feb 8, 2019 •
edited
Loading

Always register the NativeScriptDomAdapter.
It is used for console.logging when router tracing is enabled.

resolves #650 even when bundling application with webpack.

@ghost ghost assigned vakrilov Feb 8, 2019
@ghost ghost added the in progress label Feb 8, 2019
@vakrilov vakrilov changed the title fix: Router tracing does not work wiht webpack fix: Router tracing does not work with webpack Feb 8, 2019
@vakrilov vakrilov changed the base branch from master to release February 8, 2019 16:13
@vakrilov
Copy link
Contributor Author

vakrilov commented Feb 8, 2019

test package_version#rc

@vakrilov vakrilov closed this Feb 9, 2019
@ghost ghost removed the in progress label Feb 9, 2019
@vakrilov vakrilov deleted the router-tracing branch July 5, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vakrilov vakrilov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vakrilov @SvetoslavTsenov