fix(location-strategy): extend support for nested primary outlets #1717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release: cut the 7.2.0 release
ghost
added
the
ADjenkov
force-pushed
the
djenkov/nested-primary-outlets
branch
from
fd1a010 to
03915a1
Compare
vakrilov
previously approved these changes
Feb 8, 2019
| <page-router-outlet tag="rootPRO"></page-router-outlet> |
There was a problem hiding this comment.
Is the tag="rootPRO" used somewhere or just for debugging?
There was a problem hiding this comment.
it is just for debugging, since it is very easy to distinguish which p-r-o is activated, states and so on..it's also in the test app only
ADjenkov
force-pushed
the
djenkov/nested-primary-outlets
branch
2 times, most recently
from
bb0db35 to
901277d
Compare
|
test |
ADjenkov
force-pushed
the
djenkov/nested-primary-outlets
branch
from
901277d to
df484d3
Compare
|
test package_version#rc |
vakrilov
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending
LocationStatewithFrameproperty which holds theFramethat initiated the navigation for the givenLocationState. Back in parent Outlet should take care of its children states (remove all states until the currentFramethat goes back is reached).Various bug with nested primary
<page-router-outlets>where reported from both Kinvey Shared Application and the North Star project.