Skip to content

Fixed shell:package task command on Windows systems #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

PBartrina
Copy link
Contributor

The extra quotes on the command made the task crash on windows since the quote was added to the path.

The extra quotes on the command made the task crash on windows since the quote was added to the path.
@hdeshev
Copy link
Contributor

hdeshev commented Nov 5, 2015

I think there's a simpler fix for that -- just use double quotes since they work on Windows too. I fixed a similar issue here:

https://github.com/NativeScript/sample-ng-todomvc/blob/master/gruntfile.js#L80

       localInstallModules: {
           command: "npm install \"<%= nsPackagePath %>\""
       },

I'd rather stick with quotes since the command could (in theory) fail if we change the output dir to something that contains spaces.

@PBartrina
Copy link
Contributor Author

I remember seeing something like c:\pathParent\'pathSon\path' with those single quotes in the middle, that was my reason to try and avoid them, but I see it isn't the solution (nor the case, since it won't show that path in this particular piece of code)
If I see it again, I'll post an issue.

For the moment, I fixed it as you requested, using escaped double quotes.

@hdeshev
Copy link
Contributor

hdeshev commented Nov 6, 2015

I squashed the commits and merged them manually. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants