Skip to content

fix(p-r-o): needless forward navigation after back inside nested named outlet #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2018
Merged

fix(p-r-o): needless forward navigation after back inside nested named outlet #1667

merged 1 commit into from
Dec 20, 2018

Conversation

ADjenkov
Copy link
Contributor

Fix #1666

@ADjenkov ADjenkov self-assigned this Dec 17, 2018
@ghost ghost added the in progress label Dec 17, 2018
@SvetoslavTsenov
Copy link
Contributor

test --ignore templates api23 ios12

@SvetoslavTsenov
Copy link
Contributor

test --ignore templates api23 ios12 groceries

@SvetoslavTsenov
Copy link
Contributor

There is on failing test where the image is not updated.

@SvetoslavTsenov SvetoslavTsenov merged commit b439c13 into master Dec 20, 2018
@ghost ghost removed the in progress label Dec 20, 2018
@SvetoslavTsenov SvetoslavTsenov deleted the djenkov/nested-named-outlets-fix branch December 20, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manoldonev manoldonev manoldonev approved these changes

Assignees

@ADjenkov ADjenkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ADjenkov @SvetoslavTsenov @manoldonev