Skip to content

fix: crash in deactivate page router outlet #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2018
Merged

fix: crash in deactivate page router outlet #1590

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97d75bf
fix: crash in deactivate page router outlet
SvetoslavTsenov Nov 6, 2018
1e02f9a
chore: fix typo
SvetoslavTsenov Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nativescript-angular/router/page-router-outlet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export class PageRouterOutlet implements OnDestroy { // tslint:disable-line:dire
}

deactivate(): void {
if (!this.outlet.isPageNavigationBack) {
if (!this.outlet && !this.outlet.isPageNavigationBack) {
if (isLogEnabled()) {
log("Currently not in page back navigation - component should be detached instead of deactivated.");
}
Expand Down