Skip to content

test: relpace findElementByText with findElementByAutomationText #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion e2e/config/appium.capabilities.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,16 @@
"noReset": true,
"fullReset": false
},
"android28": {
"platformName": "Android",
"platformVersion": "28",
"deviceName": "Emulator-Api28-Google",
"avd": "Emulator-Api28-Google",
"lt": 60000,
"newCommandTimeout": 720,
"noReset": true,
"fullReset": false
},
"sim.iPhone7.iOS100": {
"platformName": "iOS",
"platformVersion": "10.0",
Expand All @@ -105,7 +115,7 @@
},
"sim.iPhone7.iOS110": {
"platformName": "iOS",
"platformVersion": "11.2",
"platformVersion": "11.4",
"deviceName": "iPhone 7 110",
"noReset": true,
"fullReset": false
Expand All @@ -117,11 +127,39 @@
"noReset": true,
"fullReset": false
},
"sim.iPhone8": {
"platformName": "iOS",
"platformVersion": "12",
"deviceName": "iPhone 8",
"noReset": true,
"fullReset": false
},
"sim.iPhoneX.iOS110": {
"platformName": "iOS",
"platformVersion": "11.2",
"deviceName": "iPhone X 110",
"noReset": true,
"fullReset": false
},
"sim.iPhoneX": {
"platformName": "iOS",
"platformVersion": "12.0",
"deviceName": "iPhone X",
"noReset": true,
"fullReset": false
},
"sim.iPhoneXS": {
"platformName": "iOS",
"platformVersion": "12.0",
"deviceName": "iPhone XS",
"noReset": true,
"fullReset": false
},
"sim.iPhoneXR": {
"platformName": "iOS",
"platformVersion": "12.0",
"deviceName": "iPhone XR",
"noReset": true,
"fullReset": false
}
}
35 changes: 0 additions & 35 deletions e2e/nested-router-tab-view/app/app.android.css

This file was deleted.

43 changes: 43 additions & 0 deletions e2e/nested-router-tab-view/app/app.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
Button{
color: blue;
}

TextView{
color: green;
}

Button{
font-size: 8;
padding-left: 5;
padding-right: 5;
padding-top: 0;
padding-bottom: 0;
margin-top: 0;
margin-bottom: 0;
margin-right: 0;
height: 50px;
color: blue;
}

TextView{
font-size: 10;
margin: 0;
padding: 0;
color: green;
}

Label{
font-size: 10;
margin: 0;
padding: 0;
}

GridLayout{
margin: 0;
padding: 0;
}

ActionBar{
height: 30;
margin: 0;
}
7 changes: 0 additions & 7 deletions e2e/nested-router-tab-view/app/app.ios.css

This file was deleted.

10 changes: 5 additions & 5 deletions e2e/nested-router-tab-view/e2e/home-tabs.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,26 +97,26 @@ describe("home-tabs:", () => {
});

async function backActivatedRoute(driver: AppiumDriver) {
const btnBack = await driver.findElementByText("Back(ActivatedRoute)");
const btnBack = await driver.findElementByAutomationText("Back(ActivatedRoute)");
await btnBack.tap();
}

async function backPlayers(driver: AppiumDriver) {
const btnBackPlayers = await driver.findElementByText("Back(Players)");
const btnBackPlayers = await driver.findElementByAutomationText("Back(Players)");
await btnBackPlayers.tap();
}

async function backBoth(driver: AppiumDriver) {
const btnBackBoth = await driver.findElementByText("Back(Both)");
const btnBackBoth = await driver.findElementByAutomationText("Back(Both)");
await btnBackBoth.tap();
}

async function gotoPlayersTab(driver: AppiumDriver) {
const btnTabPlayers = await driver.findElementByText("Players Tab");
const btnTabPlayers = await driver.findElementByAutomationText("Players Tab");
await btnTabPlayers.tap();
}

async function gotoTeamsTab(driver: AppiumDriver) {
const btnTabTeams = await driver.findElementByText("Teams Tab");
const btnTabTeams = await driver.findElementByAutomationText("Teams Tab");
await btnTabTeams.tap();
}
40 changes: 20 additions & 20 deletions e2e/nested-router-tab-view/e2e/screen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,108 +38,108 @@ export class Screen {
}

showDialogConfirm = async (title) => {
const btnShowDialogConfirm = await this._driver.findElementByText(title);
const btnShowDialogConfirm = await this._driver.findElementByAutomationText(title);
await btnShowDialogConfirm.tap();
}

loadedConfirmDialog = async (dialogMessage) => {
const lblDialogMessage = await this._driver.findElementByText(dialogMessage);
const lblDialogMessage = await this._driver.findElementByAutomationText(dialogMessage);
assert.isTrue(await lblDialogMessage.isDisplayed());
console.log(dialogMessage + " shown!");
}

closeDialog = async () => {
const btnYesDialog = await this._driver.findElementByText(confirmDialog);
const btnYesDialog = await this._driver.findElementByAutomationText(confirmDialog);
await btnYesDialog.click();
}

loadedLogin = async () => {
const lblLogin = await this._driver.findElementByText(login);
const lblLogin = await this._driver.findElementByAutomationText(login);
assert.isTrue(await lblLogin.isDisplayed());
console.log(login + " loaded!");
}

loadedHome = async () => {
const lblHome = await this._driver.findElementByText(home);
const lblHome = await this._driver.findElementByAutomationText(home);
assert.isTrue(await lblHome.isDisplayed());
console.log(home + " loaded!");
}

loadedTabs = async () => {
const lblTabs = await this._driver.findElementByText(tabs);
const lblTabs = await this._driver.findElementByAutomationText(tabs);
assert.isTrue(await lblTabs.isDisplayed());
console.log(tabs + " loaded!");
}

navigateToTabsPage = async () => {
const btnNavToTabsPage = await this._driver.findElementByText(gotoTabsPage);
const btnNavToTabsPage = await this._driver.findElementByAutomationText(gotoTabsPage);
await btnNavToTabsPage.tap();
}

loadedPlayersList = async () => {
const lblPlayerList = await this._driver.findElementByText(playerList);
const lblPlayerList = await this._driver.findElementByAutomationText(playerList);
assert.isTrue(await lblPlayerList.isDisplayed());
console.log(playerList + " loaded!");
}

loadedPlayerDetails = async (player) => {
const lblPlayerDetail = await this._driver.findElementByText(playerDetails);
const lblPlayerDetail = await this._driver.findElementByAutomationText(playerDetails);
assert.isTrue(await lblPlayerDetail.isDisplayed());

const lblPlayer = await this._driver.findElementByText(player + " Details");
const lblPlayer = await this._driver.findElementByAutomationText(player + " Details");
assert.isTrue(await lblPlayer.isDisplayed());

console.log(player + " Details" + " loaded!");
}

loadedTeamList = async () => {
const lblTeamList = await this._driver.findElementByText(teamList, 10);
const lblTeamList = await this._driver.findElementByAutomationText(teamList, 10);
assert.isTrue(await lblTeamList.isDisplayed());
console.log(teamList + " loaded!");
}

loadedTeamDetails = async (team) => {
const lblTeamDetail = await this._driver.findElementByText(teamDetails);
const lblTeamDetail = await this._driver.findElementByAutomationText(teamDetails);
assert.isTrue(await lblTeamDetail.isDisplayed());

const lblTeam = await this._driver.findElementByText(team + " Details");
const lblTeam = await this._driver.findElementByAutomationText(team + " Details");
assert.isTrue(await lblTeam.isDisplayed());

console.log(team + " Details" + " loaded!");
}

navigateToHomePage = async (homePageButton?) => {
const btnNavToHomePage = await this._driver.findElementByText(homePageButton || gotoHomePage);
const btnNavToHomePage = await this._driver.findElementByAutomationText(homePageButton || gotoHomePage);
await btnNavToHomePage.tap();
}

navigateToPlayer = async (player: string) => {
const btnNavPlayerPage = await this._driver.findElementByText(player);
const btnNavPlayerPage = await this._driver.findElementByAutomationText(player);
await btnNavPlayerPage.tap();
}

navigateToNextPlayer = async () => {
const btnNavPlayerNextPage = await this._driver.findElementByText(gotoNextPlayer);
const btnNavPlayerNextPage = await this._driver.findElementByAutomationText(gotoNextPlayer);
await btnNavPlayerNextPage.tap();
}

navigateToPlayers = async () => {
const btnNavPlayersPage = await this._driver.findElementByText(gotoPlayers);
const btnNavPlayersPage = await this._driver.findElementByAutomationText(gotoPlayers);
await btnNavPlayersPage.tap();
}

navigateToTeam = async (team: string) => {
const btnNavTeamPage = await this._driver.findElementByText(team);
const btnNavTeamPage = await this._driver.findElementByAutomationText(team);
await btnNavTeamPage.tap();
}

navigateToNextTeam = async () => {
const btnNavTeamNextPage = await this._driver.findElementByText(gotoNextTeam);
const btnNavTeamNextPage = await this._driver.findElementByAutomationText(gotoNextTeam);
await btnNavTeamNextPage.tap();
}

navigateToTeams = async () => {
const btnNavTeamsPage = await this._driver.findElementByText(gotoTeams);
const btnNavTeamsPage = await this._driver.findElementByAutomationText(gotoTeams);
await btnNavTeamsPage.tap();
}
}
10 changes: 5 additions & 5 deletions e2e/nested-router-tab-view/e2e/split-view.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -152,26 +152,26 @@ describe("split-view:", () => {
});

async function backActivatedRoute(driver: AppiumDriver) {
const btnBack = await driver.findElementByText("Back(ActivatedRoute)");
const btnBack = await driver.findElementByAutomationText("Back(ActivatedRoute)");
await btnBack.tap();
}

async function back(driver: AppiumDriver) {
const btnBack = await driver.findElementByText("Back()");
const btnBack = await driver.findElementByAutomationText("Back()");
await btnBack.tap();
}

async function backPlayers(driver: AppiumDriver) {
const btnBackPlayers = await driver.findElementByText("Back(Players)");
const btnBackPlayers = await driver.findElementByAutomationText("Back(Players)");
await btnBackPlayers.tap();
}

async function backTeams(driver: AppiumDriver) {
const btnBackTeams = await driver.findElementByText("Back(Teams)");
const btnBackTeams = await driver.findElementByAutomationText("Back(Teams)");
await btnBackTeams.tap();
}

async function backBoth(driver: AppiumDriver) {
const btnBackBoth = await driver.findElementByText("Back(Both)");
const btnBackBoth = await driver.findElementByAutomationText("Back(Both)");
await btnBackBoth.tap();
}
8 changes: 4 additions & 4 deletions e2e/nested-router-tab-view/e2e/tab-view.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,21 +76,21 @@ describe("tab-view:", () => {
});

async function gotoPlayersTab(driver: AppiumDriver) {
const btnTabPlayers = await driver.findElementByText("Players Tab");
const btnTabPlayers = await driver.findElementByAutomationText("Players Tab");
await btnTabPlayers.tap();
}

async function gotoTeamsTab(driver: AppiumDriver) {
const btnTabTeams = await driver.findElementByText("Teams Tab");
const btnTabTeams = await driver.findElementByAutomationText("Teams Tab");
await btnTabTeams.tap();
}

async function backTeams(driver: AppiumDriver) {
const btnBackTeams = await driver.findElementByText("Back-Teams");
const btnBackTeams = await driver.findElementByAutomationText("Back-Teams");
await btnBackTeams.tap();
}

async function backPlayers(driver: AppiumDriver) {
const btnBackPlayers = await driver.findElementByText("Back-Players");
const btnBackPlayers = await driver.findElementByAutomationText("Back-Players");
await btnBackPlayers.tap();
}
1 change: 1 addition & 0 deletions e2e/nested-router-tab-view/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"babel-traverse": "6.26.0",
"babel-types": "6.26.0",
"babylon": "6.18.0",
"chai": "^4.2.0",
"lazy": "1.0.11",
"mocha": "^5.2.0",
"mocha-junit-reporter": "^1.18.0",
Expand Down