fix(frame-service): move FrameService provider to NativeScriptModule #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in order to be singleton
ghost
added
the
vakrilov
previously approved these changes
Aug 20, 2018
MartoYankov
approved these changes
Aug 22, 2018
NathanWalker
pushed a commit
to NathanWalker/nativescript-angular
that referenced
this pull request
Oct 10, 2018
…ativeScript#1489) * fix(frame-service): move FrameService provider to NativeScriptModule in order to be singleton * chore: bump ngtools/webpack version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FrameService provider is not singleton when provided through
NativeScriptCommonModule(since it is imported for every single module in lazy loaded app).Moving FrameService to
NativeScriptModulein order to be singleton since it is not stateless (holding cached frames collection).Fix #1484