Skip to content

Commit 3b434c9

Browse files
authored
fix(frame-service): move FrameService provider to NativeScriptModule (#1489)
* fix(frame-service): move FrameService provider to NativeScriptModule in order to be singleton * chore: bump ngtools/webpack version
1 parent 5e8c092 commit 3b434c9

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Diff for: e2e/single-page/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
},
3232
"devDependencies": {
3333
"@angular/compiler-cli": "~6.1.0",
34-
"@ngtools/webpack": "~6.1.0",
34+
"@ngtools/webpack": "~6.2.0-beta.3",
3535
"@types/chai": "^4.0.2",
3636
"@types/mocha": "^2.2.41",
3737
"@types/node": "^7.0.5",

Diff for: nativescript-angular/common.ts

-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {
1212
defaultDeviceProvider,
1313
defaultFrameProvider,
1414
defaultPageProvider,
15-
FrameService,
1615
} from "./platform-providers";
1716
import { NS_DIRECTIVES } from "./directives";
1817

@@ -26,7 +25,6 @@ import { NS_DIRECTIVES } from "./directives";
2625
defaultDeviceProvider,
2726
defaultFrameProvider,
2827
defaultPageProvider,
29-
FrameService,
3028
],
3129
imports: [
3230
CommonModule,

Diff for: nativescript-angular/nativescript.module.ts

+2
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import { NativeScriptCommonModule } from "./common";
2828
import { NativeScriptRendererFactory } from "./renderer";
2929
import { DetachedLoader } from "./common/detached-loader";
3030
import { throwIfAlreadyLoaded } from "./common/utils";
31+
import { FrameService } from "./platform-providers";
3132

3233
export function errorHandlerFactory() {
3334
return new ErrorHandler();
@@ -38,6 +39,7 @@ export function errorHandlerFactory() {
3839
DetachedLoader,
3940
],
4041
providers: [
42+
FrameService,
4143
NativeScriptRendererFactory,
4244
SystemJsNgModuleLoader,
4345
{ provide: APP_ROOT, useValue: true },

0 commit comments

Comments
 (0)