Added setupItemView event for Angular ListView. #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsndeck
force-pushed
the
nnikolov/ListViewSetupItemView
branch
from
35c7c66 to
716515a
Compare
|
Travis tests fail with an obscure error: 👍 after fixing the tests issue |
|
|
||
| it('setupItemView is called for every item', (done) => { | ||
| return testApp.loadComponent(TestListViewComponent).then((componentRef) => { | ||
| const componentRoot = componentRef.instance.elementRef.nativeElement; |
There was a problem hiding this comment.
componentRoot and listView not needed
|
👍 |
nsndeck
force-pushed
the
nnikolov/ListViewSetupItemView
branch
2 times, most recently
from
d92c71a to
9873053
Compare
nsndeck
force-pushed
the
nnikolov/ListViewSetupItemView
branch
from
9873053 to
9e30852
Compare
|
View your CI Pipeline Execution ↗ for commit 9e30852.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.