chore(modal-navigation): add reset root view mechanism #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ADjenkov
force-pushed
the
djenkov/e2e-reset-root
branch
3 times, most recently
from
f6d5580 to
f9d30b9
Compare
vakrilov
previously approved these changes
Jun 26, 2018
| bootstrap: [ | ||
| AppComponent | ||
| ], | ||
| // bootstrap: [ |
| @@ -30,9 +30,9 @@ | |||
| "zone.js": "~0.8.2" | |||
| }, | |||
| "devDependencies": { | |||
| "@angular-devkit/core": "~0.6.3", | |||
| "@angular-devkit/core": "~0.7.0-beta.1", | |||
There was a problem hiding this comment.
Are these dependencies intended?
ADjenkov
force-pushed
the
djenkov/e2e-reset-root
branch
from
ac9dff3 to
aa9b904
Compare
vakrilov
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset root view works with
--bundleand--env.aotDepending on PR that makes the
livesyncmethod public