fix(tabview): implemented setter for TabViewItem's config #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
test |
|
test |
2 similar comments
|
test |
|
test |
|
test |
MartoYankov
approved these changes
Jun 25, 2018
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a setter for the configuration so that the binding can change the configuration and apply the changes to the underlying view. I kept all of the previous getters/setters decorated as inputs even tough they are not working as expected. This is for compatibility reasons and can be challenged. The implementation of each has been adapted to use the new configuration setter to apply the configuration change.
Fixes #845