Skip to content

fix(router): state is not guarded before use #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2018
Merged

fix(router): state is not guarded before use #1331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion nativescript-angular/router/ns-location-strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,12 @@ export class NSLocationStrategy extends LocationStrategy {
return "/";
}

let tree = this.currentUrlTree;
const state = this.peekState(this.currentOutlet);
if (!state) {
return "/";
}

let tree = this.currentUrlTree;

// Handle case where the user declares a component at path "/".
// The url serializer doesn't parse this url as having a primary outlet.
Expand Down