fix(router): state is not guarded before use #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`state` is not guarded before use, but `peekState` may return null. Appears to have been introduced [here](NativeScript@b98da83#diff-a7820fa2a2eb0ce14f3f0b8bfc666dd5R49). Before those changes, `state` was guarded. May result in the following stack, seen on some older iOS devices (2-3 years) when rapidly navigating: ``` CONSOLE ERROR file:///app/tns_modules/@angular/core/bundles/core.umd.js:1682:24: ERROR TypeError: undefined is not an object (evaluating 'state.isPageNavigation') CONSOLE ERROR file:///app/tns_modules/@angular/core/bundles/core.umd.js:1682:24: ERROR TypeError: undefined is not an object (evaluating 'state.isPageNavigation') CONSOLE ERROR file:///app/tns_modules/@angular/core/bundles/core.umd.js:1682:24: ERROR Error: Uncaught (in promise): TypeError: null is not an object (evaluating 'state.isRootSegmentGroup') path@file:///app/tns_modules/nativescript-angular/router/ns-location-strategy.js:33:18 get@file:///app/tns_modules/nativescript-angular/router/ns-platform-location.js:38:46 path@file:///app/tns_modules/@angular/common/bundles/common.umd.js:589:46 path@file:///app/tns_modules/@angular/common/bundles/common.umd.js:247:58 isCurrentPathEqualTo@file:///app/tns_modules/@angular/common/bundles/common.umd.js:260:25 file:///app/tns_modules/@angular/router/bundles/router.umd.js:4158:56 file:///app/tns_modules/rxjs/internal/Observable.js:203:25 __tryOrUnsub@file:///app/tns_modules/rxjs/internal/Subscriber.js:263:20 next@file:///app/tns_modules/rxjs/internal/Subscriber.js:201:34 _next@file:///app/tns_modules/rxjs/internal/Subscriber.js:139:30 next@file:///app/tns_modules/rxjs/internal/Subscriber.js:103:23 _next@file:///app/tns_module ```
ghost
added
the
|
test |
manoldonev
approved these changes
May 18, 2018
MartoYankov
approved these changes
May 21, 2018
sis0k0
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stateis not guarded before use, butpeekStatemay return null.Appears to have been introduced here.
Before those changes,
statewas guarded.May result in the following stack, seen on some older iOS devices (2-3 years) when rapidly navigating: