Skip to content

Modal dialog service #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2016
Merged

Modal dialog service #127

merged 5 commits into from
Mar 24, 2016

Conversation

vakrilov
Copy link
Contributor

Resolves #98

@NathanWalker
Copy link
Contributor

woo-hoo! Thanks @vakrilov !

@vakrilov vakrilov closed this Mar 22, 2016
@vakrilov vakrilov reopened this Mar 23, 2016
@anhoev
Copy link

anhoev commented Mar 24, 2016

This is cool . Does it support custom template or only text ?

@vakrilov
Copy link
Contributor Author

@anhoev You pass a component type to the showModal method and it loads it in a dialog - like that.

@anhoev
Copy link

anhoev commented Mar 24, 2016

@vakrilov 👍
Super !

})
.then((compRef) => {
//Component loaded. Find its root native view.
const componenetView = <View>compRef.location.nativeElement;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: componentView

@hdeshev
Copy link
Contributor

hdeshev commented Mar 24, 2016

💯

@vakrilov vakrilov merged commit ed814c6 into master Mar 24, 2016
@vakrilov vakrilov deleted the modal-pages branch March 24, 2016 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants