Skip to content

feat: Added createFrameOnBootstrap bootstrap option for back compat #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2018
Merged

feat: Added createFrameOnBootstrap bootstrap option for back compat #1259

merged 3 commits into from
Apr 2, 2018

Conversation

vakrilov
Copy link
Contributor

Added an createFrameOnBootstrap bootstrap option to be used in cases when you want the platform to automatically create Frame and Page on bootstrap:
Usage:

platformNativeScript({ createFrameOnBootstrap: true })
     .bootstrapModuleFactory(AppModuleNgFactory);

@ghost ghost assigned vakrilov Mar 29, 2018
@ghost ghost added the in progress label Mar 29, 2018
@vakrilov
Copy link
Contributor Author

test

@vakrilov vakrilov merged commit f3e455e into master Apr 2, 2018
@vakrilov vakrilov deleted the compat-option branch April 2, 2018 10:58
@ghost ghost removed the in progress label Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartoYankov MartoYankov MartoYankov approved these changes

@sis0k0 sis0k0 Awaiting requested review from sis0k0

@vchimev vchimev Awaiting requested review from vchimev

Assignees

@vakrilov vakrilov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vakrilov @MartoYankov