Skip to content

docs: describe comment messages available to test #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2017
Merged

Conversation

vchimev
Copy link
Contributor

@vchimev vchimev commented Oct 6, 2017

No description provided.

@ghost ghost assigned vchimev Oct 6, 2017
@ghost ghost added the in progress label Oct 6, 2017
Copy link
Contributor

@sis0k0 sis0k0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add some notes about:

  • travis builds;
  • what is triggered on community PRs;
  • who has rights to trigger which builds (Travis, Jenkins);
  • the location of the app and the tests for each build?


### Travis

This build compiles the `nativescript-angular` plugin and builds the [tests](https://github.com/NativeScript/nativescript-angular/tree/master/tests) app for Android. Please, refer to the [.travis.yml](https://github.com/NativeScript/nativescript-angular/blob/master/.travis.yml) config file for complete information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"builds the nativescript-angular package" instead


### Jenkins

More extensive tests execute in Jenkins CI. The table below describes how to trigger and the location of the app/tests of all builds available to execute tests on pull requests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note again that these can't be triggered externally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention that to manually trigger a build, you need to comment inside the PR.

@vchimev vchimev merged commit 45d6edf into master Oct 16, 2017
@vchimev vchimev deleted the vchimev-pr-tests branch October 16, 2017 12:52
@ghost ghost removed the in progress label Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants