Skip to content

[4.2] Nested Router outlet stops working after page navigation #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vakrilov opened this issue Aug 18, 2017 · 8 comments
Closed

[4.2] Nested Router outlet stops working after page navigation #949

vakrilov opened this issue Aug 18, 2017 · 8 comments
Assignees
@vakrilov
Labels
bug severity: high
Milestone
4.4

Comments

@vakrilov
Copy link
Contributor

vakrilov commented Aug 18, 2017 •
edited
Loading

Nested <router-outlet> stops working after page navigation.
The problem occurs when you have <router-outlet> nested inside a <page-router-outlet>. When you navigate to another page and then back again, the nested <router-outlet> remains empty and you can no longer navigate in it.

Repro:

  1. Run this sample from the ng-sample app
  2. Click "Start" -> navigates to second page with nested outlet (green background)
  3. Click "Nav to First" -> forward navigation the first page
  4. Click back -> we are back to the previous page, but the nested outlet (with the green background) is gone

Issue reproducible for both Android and IOS.
@jogboms
Copy link

jogboms commented Aug 19, 2017

Mentioned this issue already and even created a sample to prove it too #941

@davidjonz2005
Copy link

i have the same problem,
i have a tabview with three tab and each of them is a router-outlet when i go to another page and back again all of them disapeared

@vakrilov vakrilov added this to the 4.3 milestone Aug 21, 2017
@davidjonz2005
Copy link

i think as a workaround we can use "ngIf" instead of "router-outlet" statement. any better suggesion?

@vakrilov vakrilov self-assigned this Aug 23, 2017
vakrilov pushed a commit that referenced this issue Sep 4, 2017
refactor(router): Implemented page caching with RouteReuseStrategy (#949
ad86d12 
)
vakrilov pushed a commit that referenced this issue Sep 4, 2017
refactor(router): Do page navigation with RouteReuseStrategy (#949)
267ee38
vakrilov pushed a commit that referenced this issue Sep 4, 2017
refactor(router): Do page navigation with RouteReuseStrategy (#949)
ab952e0
vakrilov pushed a commit that referenced this issue Sep 4, 2017
refactor(router): Do page navigation with RouteReuseStrategy (#949)
497f56d
sis0k0 pushed a commit that referenced this issue Sep 7, 2017
@sis0k0
refactor(router): Do page navigation with RouteReuseStrategy (#949)
95d3311
vakrilov pushed a commit that referenced this issue Sep 7, 2017
refactor(router): Implement page navigation with RouteReuseStrategy (#…
78e6625 
…949) (#977)

* refactor(router): Do page navigation with RouteReuseStrategy (#949)

* test(router): Router e2e tests

* refactor(typo): Fix mor typos
sis0k0 added a commit that referenced this issue Sep 14, 2017
@sis0k0
Revert "refactor(router): Implement page navigation with RouteReuseSt…
63b652d 
…rategy (#949) (#977)"

This reverts commit 78e6625.
sis0k0 added a commit that referenced this issue Sep 14, 2017
@sis0k0
Revert "refactor(router): Implement page navigation with RouteReuseSt…
e5cc581 
…rategy (#949) (#977)" (#991)

This reverts commit 78e6625.
vakrilov pushed a commit that referenced this issue Sep 15, 2017
refactor(router): Do page navigation with RouteReuseStrategy (#949)
2a781de
vakrilov pushed a commit that referenced this issue Sep 18, 2017
refactor(router): Do page navigation with RouteReuseStrategy (#949)
d7b44ce
vakrilov pushed a commit that referenced this issue Sep 21, 2017
refactor(router): Second try: Implement page navigation with RouteReu…
258ce98 
…seStrategy (#949) (#993)

* refactor(router): Do page navigation with RouteReuseStrategy (#949)

* test(router): Router e2e tests

* refactor(typo): Fix mor typos

* test(router): Added lazy module in e2e proj

* test(router): Added componentless routes

* fix(router): Handle multiple ActivatedRoutes associated to single palge outlet
@blueberrynotblue
Copy link

@vakrilov did this solved in 4.4?

@vakrilov
Copy link
Contributor Author

Just deleted my last comment - it was intended for another issue.

This issue is fixed and already in @next. It will be also included in the 4.4.0 release

@ghost ghost removed the in progress label Oct 11, 2017
@jevenson
Copy link

@vakrilov Did this get pushed with 4.4.0? I'm not seeing it listed in the changelog

@corne-de-bruin corne-de-bruin mentioned this issue Nov 14, 2017
Open
@hackerunet
Copy link

Sorry but this was not included in any other version, in fact the version 4.4 has not been released yet and @next leades me to version 5.0 which I tested and the problem persist.

@gonick
Copy link

gonick commented Nov 8, 2018 •
edited
Loading

Any resolution to this problem?
After opening a route through page-router-outlet
router-outlet navigations stopes working.
🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vakrilov vakrilov

Labels
bug severity: high
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
7 participants
@hackerunet @vakrilov @jogboms @jevenson @davidjonz2005 @blueberrynotblue @gonick