Skip to content

Global css styles in components with ViewEncapsulation.None doesn't apply #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sis0k0 opened this issue May 11, 2017 · 0 comments · Fixed by #812
Closed

Global css styles in components with ViewEncapsulation.None doesn't apply #794

sis0k0 opened this issue May 11, 2017 · 0 comments · Fixed by #812
Assignees
@sis0k0
Labels
bug
Milestone
3.1

Comments

@sis0k0
Copy link
Contributor

sis0k0 commented May 11, 2017

When the component's encapsulation is set to None, it's expected that the css styles in the component will be set as global. In the current implementation of the renderer, such component's use the default, NativeScriptRenderer, which doesn't apply the styles.
The fix is relatively easy - when using the default rednerer, just apply component styles with the addCss method from tns_modules/application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sis0k0 sis0k0

Labels
bug
Projects
None yet
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

fix(renderer): add styles when ViewEncapsulation is None NativeScript/nativescript-angular
1 participant
@sis0k0