-
-
Notifications
You must be signed in to change notification settings - Fork 241
ActionItems are displayed in the wrong order using *ngIf #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @m-abs,
|
sis0k0
added a commit
that referenced
this issue
Sep 4, 2017
ActionBar's insertChild method is now passed a `next` view argument. When the view to insert is an ActionItem, `next` is used to find the correct position to insert the new item. fixes #689
sis0k0
added a commit
that referenced
this issue
Sep 7, 2017
ActionBar's insertChild method is now passed a `next` view argument. When the view to insert is an ActionItem, `next` is used to find the correct position to insert the new item. fixes #689
sis0k0
added a commit
that referenced
this issue
Sep 7, 2017
refactor(renderer): invoke removeFromQueue for every element refactor(action-bar): insert ActionItems at correct positions ActionBar's insertChild method is now passed a next view argument. When the view to insert is an ActionItem, next is used to find the correct position to insert the new item. refactor(renderer): patch every View with ViewExtensions When a View is passed through the renderer on insert/remove it's patched with ViewExtensions for its class. That is done for parent views and for child views. fixes #689, fixes #978
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you have an
ActionBar
with optionalActionItems
, the items switches place when the*ngIf
state changes.You can see what I mean in this gif:

There are two
ActionItem
, one with the title=1 and one with the title=2.ActionItem 1
.ActionItem 1
again, but now on the right side ofActionItem 2
ActionItem 2
ActionItem 2
again, now in the proper orderI would expect the items to be shown in the order they're in the template:
I have a demo project here:
https://github.com/m-abs/tns-webpack-ng2.3/tree/action-ngIf-order
The text was updated successfully, but these errors were encountered: