Skip to content

Update renderer to use latest api changes from beta.1 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NathanWalker opened this issue Jan 13, 2016 · 3 comments
Closed

Update renderer to use latest api changes from beta.1 #34

NathanWalker opened this issue Jan 13, 2016 · 3 comments

Comments

@NathanWalker
Copy link
Contributor

I was starting to look at updating renderer.ts to the latest api changes with beta.1, which the entire interface changed. If someone else is already working on updating that, please let me know as not to duplicate efforts ;)

Changes:
https://github.com/angular/angular/blob/master/modules/angular2/src/core/render/api.ts

Current errors with latest:

/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(2,9): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderComponentTemplate'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(6,5): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderEventDispatcher'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(7,5): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderElementRef'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(8,5): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderProtoViewRef'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(9,5): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderViewRef'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(10,5): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderFragmentRef'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(11,5): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderViewWithFragments'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(12,5): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderTemplateCmd'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(26,14): error TS2415: Class 'NativeScriptRenderer' incorrectly extends base class 'Renderer'.
  Types of property 'createElement' are incompatible.
    Type '(name: string, attrNameAndValues: string[]) => ViewNode' is not assignable to type '(parentElement: any, name: string) => any'.
      Types of parameters 'attrNameAndValues' and 'name' are incompatible.
        Type 'string[]' is not assignable to type 'string'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(26,14): error TS2515: Non-abstract class 'NativeScriptRenderer' does not implement inherited abstract member 'attachViewAfter' from class 'Renderer'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(26,14): error TS2515: Non-abstract class 'NativeScriptRenderer' does not implement inherited abstract member 'createViewRoot' from class 'Renderer'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(26,14): error TS2515: Non-abstract class 'NativeScriptRenderer' does not implement inherited abstract member 'detachView' from class 'Renderer'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(26,14): error TS2515: Non-abstract class 'NativeScriptRenderer' does not implement inherited abstract member 'listen' from class 'Renderer'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(26,14): error TS2515: Non-abstract class 'NativeScriptRenderer' does not implement inherited abstract member 'listenGlobal' from class 'Renderer'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(26,14): error TS2515: Non-abstract class 'NativeScriptRenderer' does not implement inherited abstract member 'projectNodes' from class 'Renderer'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(26,14): error TS2515: Non-abstract class 'NativeScriptRenderer' does not implement inherited abstract member 'renderComponent' from class 'Renderer'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/app/nativescript-angular/renderer.ts(26,14): error TS2515: Non-abstract class 'NativeScriptRenderer' does not implement inherited abstract member 'selectRootElement' from class 'Renderer'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/view.d.ts(1,10): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderComponentTemplate'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/view.d.ts(1,35): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderViewRef'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/view.d.ts(1,50): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderEventDispatcher'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/view.d.ts(1,73): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderTemplateCmd'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/view.d.ts(1,92): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderProtoViewRef'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/view.d.ts(1,112): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderFragmentRef'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/view_factory.d.ts(1,10): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderTemplateCmd'.
/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/view_factory.d.ts(1,29): error TS2305: Module '"/Users/nathanbackup/Documents/github_projects/nativescript-stuff/nativescript-angular/ng-sample/node_modules/angular2/src/core/render/api"' has no exported member 'RenderComponentTemplate'.
@hdeshev
Copy link
Contributor

hdeshev commented Jan 14, 2016

@NathanWalker I'm working on it, and it looks like it's gonna have pretty big impact on the internal code. For example, I'm removing the intermediate ViewNode object, so we can use regular NativeScript View instances.

@NathanWalker
Copy link
Contributor Author

@hdeshev It did look pretty drastic. But certainly for the better, will be much cleaner!
I'll leave this open for you to close then, lemme know if I can assist in anyway.

@NathanWalker
Copy link
Contributor Author

This was fixed here:
#35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants