Skip to content

[Tabs] TabStripItem does not render #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vchimev opened this issue Jul 1, 2019 · 1 comment
Closed

[Tabs] TabStripItem does not render #1884

vchimev opened this issue Jul 1, 2019 · 1 comment

Comments

@vchimev
Copy link
Contributor

vchimev commented Jul 1, 2019 •
edited
Loading

Environment

  • nativescript-angular: 8.0.2-rc-2019-07-01-155323-01

Describe the bug

A TabStripItem with a Label and an Image does not render.

To Reproduce - a sample tabs component.

Expected

All three items render with a title and an image.

Actual

Screenshot_1561996640
@MartoYankov MartoYankov mentioned this issue Jul 1, 2019
Closed
87 tasks
vchimev added a commit to NativeScript/NativeScript that referenced this issue Jul 5, 2019
@vchimev
feat(android-tabs): create tab item spec from image and label
bac843a 
Implements NativeScript/nativescript-angular#1884 for Android.
vchimev added a commit to NativeScript/NativeScript that referenced this issue Jul 5, 2019
@vchimev
feat(ios-tabs): tab bar item appearance
9cdbd5a 
Implements #7436 and NativeScript/nativescript-angular#1884.
@vchimev vchimev mentioned this issue Jul 5, 2019
Merged
5 tasks
ADjenkov pushed a commit to NativeScript/NativeScript that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
feat(android-tabs): create tab item spec from image and label
521e328 
Implements NativeScript/nativescript-angular#1884 for Android.
ADjenkov pushed a commit to NativeScript/NativeScript that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
feat(ios-tabs): tab bar item appearance
a740b6f 
Implements #7436 and NativeScript/nativescript-angular#1884.
ADjenkov pushed a commit to NativeScript/NativeScript that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
feat(android-tabs): create tab item spec from image and label
7098a14 
Implements NativeScript/nativescript-angular#1884 for Android.
ADjenkov pushed a commit to NativeScript/NativeScript that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
feat(ios-tabs): tab bar item appearance
bbde3cb 
Implements #7436 and NativeScript/nativescript-angular#1884.
ADjenkov pushed a commit to NativeScript/NativeScript that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
refactor(tabs): strip item appearance and creation (#7466)
c34a48a 
* test(e2e): add tab strip items pages

* fix(ios-tabs): a crash on swiping a content item

Fixes #7459.

* feat(android-tabs): create tab item spec from image and label

Implements NativeScript/nativescript-angular#1884 for Android.

* feat(ios-tabs): tab bar item appearance

Implements #7436 and NativeScript/nativescript-angular#1884.

* refactor(ios-tabs): move _hasImage and _hasTitle properties
ADjenkov pushed a commit to NativeScript/NativeScript that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
feat(ios-tabs): tab bar item appearance
fd1983f 
Implements #7436 and NativeScript/nativescript-angular#1884.
ADjenkov pushed a commit to NativeScript/NativeScript that referenced this issue Jul 10, 2019
@vchimev @ADjenkov
refactor(bottom-navigation): strip item creation (#7477)
eb1ed3e 
* feat(ios-tabs): tab bar item appearance

Implements #7436 and NativeScript/nativescript-angular#1884.

* refactor(ios-tabs): move _hasImage and _hasTitle properties

* feat(ios-bottom-navigation): create tab bar from image nad label

Implements NativeScript/nativescript-angular#1893 for iOS.

* feat(android-bottom-navigation): create tab item spec from image and label

Implements NativeScript/nativescript-angular#1893 for Android.

* chore: remove console.logs
@MartoYankov
Copy link
Contributor

This appears to be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartoYankov @vchimev