Skip to content

fix(animations): inject document object in the animation engine #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 21, 2018

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Jun 21, 2018

Should be merged with rebase and merge.
Caused by API changes in angular/angular#23300.

BREAKING CHANGE

You have to update your @angular/* dependencies to 6.0.6 due to changes
in the @angular/animations API.

fixes #1393

sis0k0 added 2 commits June 21, 2018 11:47
BREAKING CHANGE

You have to update your @angular/* dependencies to 6.0.6 due to changes
in the @angular/animations API.
@ghost ghost assigned sis0k0 Jun 21, 2018
@ghost ghost added the in progress label Jun 21, 2018
@sis0k0 sis0k0 requested a review from vakrilov June 21, 2018 13:36
@sis0k0
Copy link
Contributor Author

sis0k0 commented Jun 21, 2018

Test applications: NativeScript/ns-ng-animation-examples#4, NativeScript/ns-ng-routable-animations#3.
You need to install the .tgz from this branch of nativescript-angular to make it work.

@sis0k0 sis0k0 merged commit 379e958 into master Jun 21, 2018
@ghost ghost removed the in progress label Jun 21, 2018
@sis0k0 sis0k0 deleted the sis0k0/6.0.6-animations branch June 21, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@angular/animations 6.0.6 API breaks NativeScriptAnimationModule
2 participants