Skip to content

@angular/animations 6.0.6 API breaks NativeScriptAnimationModule #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sis0k0 opened this issue Jun 21, 2018 · 0 comments · Fixed by #1395
Closed

@angular/animations 6.0.6 API breaks NativeScriptAnimationModule #1393

sis0k0 opened this issue Jun 21, 2018 · 0 comments · Fixed by #1395
Assignees
@sis0k0

Comments

@sis0k0
Copy link
Contributor

sis0k0 commented Jun 21, 2018 •
edited
Loading

The NativeScriptAnimationModule should be updated to use the latest changes in the Angular Animations API. Now the nativescript-angular plugin fails to transpile with:

animations/animations.module.ts(25,9): error TS2554: Expected 3 arguments, but got 2.

The API was changed with angular/angular#23300, which is part of the @angular/animations 6.0.6 release.
sis0k0 added a commit that referenced this issue Jun 21, 2018
@sis0k0
fix(animations): inject document object in the animation engine
7d1bc55 
Caused by API changes in angular/angular#23300.
fixes #1393
@NickIliev NickIliev added the bug label Jun 21, 2018
@sis0k0 sis0k0 mentioned this issue Jun 21, 2018
Merged
@ghost ghost assigned sis0k0 Jun 21, 2018
@ghost ghost added the in progress label Jun 21, 2018
@ghost ghost removed bug in progress labels Jun 21, 2018
sis0k0 added a commit that referenced this issue Jun 21, 2018
@sis0k0
fix(animations): inject document object in the animation engine (#1395)
379e958 
Should be merged with `rebase and merge`.
Caused by API changes in angular/angular#23300.

BREAKING CHANGE

You have to update your @angular/* dependencies to 6.0.6 due to changes
in the @angular/animations API.

fixes #1393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sis0k0 sis0k0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(animations): inject document object in the animation engine NativeScript/nativescript-angular
2 participants
@sis0k0 @NickIliev