Change the way karma communicate with CLI #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently karma-nativescript-launcher was spawning new CLI process. From now on CLI will start karma in a forked process. So we have to send information to CLI for karma's configuration after it's been started. Remove listening for `file_list_modified` event as we already have file system watchers in CLI.
This was referenced Feb 25, 2016
|
ping @ligaz , @teobugslayer , @hdeshev , @Mitko-Kerezov |
|
most excellent, 👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Feb 26, 2016
Change the way karma communicate with CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently karma-nativescript-launcher was spawning new CLI process. From now on CLI will start karma in a forked process.
So we have to send information to CLI for karma's configuration after it's been started.
Remove listening for
file_list_modifiedevent as we already have file system watchers in CLI.