Use fork instead of spawn for tns command #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using spawn we communicate to the tns process through stdin. This is causing exception in buildMetadata step when gradle wrapper is used. For some reason it throws error in java code. Replace the spawn with fork. Fork requires JavaScript module, so use the nativescript-cli.js from bin folder in case the provided options do not send path to tns. The child process will send "ready" to the parent, when it is ready to read data. In this moment the parent will send the configuration and the unit testing will start.
|
ping @ligaz, @tailsu , @teobugslayer , @Fatme |
|
👍 |
|
Should we bump the version in package.json too? |
Set version to 0.3.0 (not to 0.2.1) as the change in communication with nativescript-cli is breaking.
|
@teobugslayer - done, I've set it to 0.3.0 :) |
rosen-vladimirov
added a commit
that referenced
this pull request
Nov 18, 2015
Use fork instead of spawn for tns command
| runner.on('message', function(data) { | ||
| if (data === "ready") { | ||
| // Child process is ready to read the data | ||
| var optionsStr = JSON.stringify(launcherConfig.options); |
There was a problem hiding this comment.
process.send already does that for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using spawn we communicate to the tns process through stdin. This is causing exception in buildMetadata step when gradle wrapper is used.
For some reason it throws error in java code.
Replace the spawn with fork. Fork requires JavaScript module, so use the nativescript-cli.js from bin folder in case the provided options do not send path to tns.
The child process will send "ready" to the parent, when it is ready to read data. In this moment the parent will send the configuration and the unit testing will start.