Skip to content

fix: exclude the AppleTV devices from the device discovery #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2019
Merged

fix: exclude the AppleTV devices from the device discovery #62

merged 1 commit into from
Oct 4, 2019

Conversation

DimitarTachev
Copy link
Contributor

@DimitarTachev DimitarTachev commented Oct 3, 2019 •
edited
Loading

KristianDD
KristianDD reviewed Oct 3, 2019
View reviewed changes
IOSDeviceLib/IOSDeviceLib.cpp
Comment on lines +300 to 301
json result = nullptr;
result[kDeviceId] = device_identifier;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too, but it's working. It should be the same. The updated version is more clear, as we are comparing with nullptr below.

@DimitarTachev DimitarTachev force-pushed the tachev/exclude-apple-tvs branch from ee58d3c to 320eb7c Compare October 3, 2019 12:22
@DimitarTachev DimitarTachev merged commit d5038a1 into master Oct 4, 2019
@DimitarTachev DimitarTachev deleted the tachev/exclude-apple-tvs branch October 4, 2019 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristianDD KristianDD KristianDD left review comments

@Fatme Fatme Fatme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DimitarTachev @Fatme @KristianDD