fix: don't stuck on "Restarting application" when some error occurs while stopping the application #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hile stopping the application Currently when the application is stopped, NativeScript CLI hangs up on "Restarting application". This happens as we're no able to start `gdb server` due to some error. (for example, not mounted developer disk image on device). In this situation, `ios-device-lib` doesn't print any message back to the CLI and this way the entire `tns run` command is blocked. Printing error in this situation will ensure that NativeScript CLI will continue the command execution. Rel to NativeScript/nativescript-cli#5020
DimitarTachev
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the application is stopped, NativeScript CLI hangs up on "Restarting application". This happens as we're no able to start
gdb serverdue to some error. (for example, not mounted developer disk image on device). In this situation,ios-device-libdoesn't print any message back to the CLI and this way the entiretns runcommand is blocked. Printing error in this situation will ensure that NativeScript CLI will continue the command execution.Rel to NativeScript/nativescript-cli#5020