fix: setTimeout does not work on Windows #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the pthread_cancel function is not available on Windows, change the definition of setTimeout method - from now on when you want to use it, you should pass the timeout, the data that you want to be passed to the function that will be executed in case the timeout passes and the function itself. The setTimeout method automatically allocates memory for the objects, so they will still live even when the function from which you call the setTimeout finishes its execution. It is not a good idea to capture variables (with lambda functions) when we'll use them in a separate thread. As we do not await the execution of the thread, the captured variables may be cleared (method from which we've called setTimeout finished its execution). More information is available here http://bannalia.blogspot.com/2016/07/passing-capturing-c-lambda-functions-as.html NOTE: Changes are not handled for macOS. NOTE: Allocated memory should be cleaned in clearTimeout as well.
* clear connection from dictionary when invalidating it * add mutex while cleaning the connection
Fatme
force-pushed
the
vladimirov/settimeout-windows
branch
from
d4be10b to
433515b
Compare
DimitarTachev
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the pthread_cancel function is not available on Windows, change the definition of setTimeout method - from now on when you want to use it, you should pass the timeout, the data that you want to be passed to the function that will be executed in case the timeout passes and the function itself.
The setTimeout method automatically allocates memory for the objects, so they will still live even when the function from which you call the setTimeout finishes its execution.
It is not a good idea to capture variables (with lambda functions) when we'll use them in a separate thread. As we do not await the execution of the thread, the captured variables may be cleared (method from which we've called setTimeout finished its execution). More information is available here http://bannalia.blogspot.com/2016/07/passing-capturing-c-lambda-functions-as.html