fix: add timeout when awaiting notification response #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
changed the title
All socket connections were changed and now are started in ssl mode. This changes the way messages are sent and received from sockets. As a result, `timeout` option is not anymore respected when receiving messages from socket. However, the messages now are received only via methods from mobile device lib. As there isn't a built-in method in mobile device that can work with timeout, we implemented timeout mechanism using new thread. `AMDServiceConnectionReceive` blocks the current thread when application is not running on device. After the provided timeout, the socket connection is invalidated and this way the current thread is freed.
Fatme
force-pushed
the
fatme/await-notification
branch
from
fa701c8 to
df52dfe
Compare
DimitarTachev
approved these changes
Aug 28, 2019
Co-Authored-By: Dimitar Tachev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All socket connections were changed and now are started in ssl mode. This changes the way messages are sent and received from sockets. As a result,
timeoutoption is not anymore respected when receiving messages from socket. However, the messages now are received only via methods from mobile device lib. As there isn't a built-in method in mobile device that can work with timeout, we implemented timeout mechanism using threads. Theawait_notification_responseoperation is started in separate thread and after the provided timeout, the started thread is terminated.Rel to NativeScript/nativescript-cli#4966