Skip to content

fix: optimize message receive for big messages #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2019
Merged

fix: optimize message receive for big messages #51

merged 1 commit into from
Jun 7, 2019

Conversation

vtrifonov
Copy link
Contributor

related to NativeScript/nativescript-cli#4226

Seems that the following code causes 100% CPU usage:

memcpy(temp, result, final_length);	
memcpy(temp + final_length, buffer, bytes_read);

so the code is refactored to use std::string

@rosen-vladimirov
Copy link
Contributor

Awesome work!

@rosen-vladimirov rosen-vladimirov merged commit 8210ad0 into master Jun 7, 2019
@rosen-vladimirov rosen-vladimirov deleted the trifonov/optimize-message-receive branch June 7, 2019 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosen-vladimirov rosen-vladimirov Awaiting requested review from rosen-vladimirov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtrifonov @rosen-vladimirov