Skip to content

Close afc connection after each file operation #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented May 31, 2018

In case when the user tries to list/read/upload/delete some application's file from device everything is ok -> the operation is successful. After that if the user tries to list/read/upload/delete from another application, afcFileRefOpen returns code 11 and an error result is printed. This leads to slow livesync in Sidekick because every another opened application (except the first open) installs the app on device. This fix will make the livesync in Sidekick faster.

Steps to reproduce:

  1. Install two applications on device
  2. Open the first one in Sidekick and run it on device - In logs you'll see the prepare and installation of the application are skipped
  3. Open the second one app in Sidekick and run it on device - In logs you'll see the "Installing..." message

@Fatme Fatme force-pushed the fatme/fix-afc-connections branch from b2a60ca to cfe6614 Compare May 31, 2018 12:37
@rosen-vladimirov rosen-vladimirov merged commit dffc818 into master Jun 5, 2018
@rosen-vladimirov rosen-vladimirov deleted the fatme/fix-afc-connections branch June 5, 2018 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants