Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Update publishing-android-apps.md #496

Merged
merged 1 commit into from
Nov 25, 2016
Merged

Conversation

dotlens
Copy link
Contributor

@dotlens dotlens commented Sep 7, 2016

For Nativescript apps with angular the information was wrong and the styling was misleading.

@tjvantoll
Copy link
Contributor

Hey @dotlens,

Sorry for the late reply here. Could you provide a little more information on the problem that you ran into? In theory a NativeScript app’s nativescript.id in package.json and android.defaultConfig.applicationId in app.gradle should match up, and changing the value in the package.json is the recommended approach.

I just gave that a shot in a new Angular app and it worked for me as expected.

@dotlens
Copy link
Contributor Author

dotlens commented Oct 3, 2016

Hey @tjvantoll

Indeed it would make sense to change it in the package.json file. But I just tested it with two nativescript-angular projects of mine and it did not work. When I changed the package name in "app\package.json" there was no effect. I had to change it in "app\App_Resources\Android\app.gradle".

I did it as it was proposed:

  1. Change nativescript.id in the package.json
  2. remove the "platforms\android" folder
  3. run "tns prepare android"
  4. run "tns run android"
  5. check "platforms\android\build\intermediates\manifests\full\F0F1\debug\AndroidManifest.xml" --> not correct
    6 check deployed package name --> not correct

Then I tried it with the app.gradle file:

  1. Change the "android.defaultConfig.applicationId" in the "app\App_Resources\Android\app.gradle"
    2-6 as before --> correct output

I hope this information could help you

Btw: The formatting of the text was also not good. There was no separation between the second bullet point and the following text which is confusing.

Cheers Claudio

PS: Im using tns-core-modules 2.3.0 and nativescript-angular 1.0.1

@tjvantoll
Copy link
Contributor

Thanks for the detail @dotlens—much appreciated, and I was able to recreate.

I actually think this is a bug in our CLI so I opened up a discussion there: NativeScript/nativescript-cli#2089. Regardless, either our CLI needs to be updated or our docs. Thanks for reporting this; we have to figure out which is correct now 😄

@NickIliev NickIliev merged commit 341edcf into NativeScript:master Nov 25, 2016
@lock
Copy link

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants