This repository was archived by the owner on Nov 17, 2022. It is now read-only.
docs(webpack): add custom application and activity section #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etabakov
reviewed
Jul 10, 2018
|
|
||
| ### Extend Android Application | ||
|
|
||
| If your project extends android application, it should be added as an [entry](https://github.com/NativeScript/nativescript-dev-webpack/blob/master/demo/AngularApp/webpack.config.js#L71) to the `webpack.config.js` file. |
There was a problem hiding this comment.
- "extends android application" should be "extends an Android application"
|
|
||
| In this way, the source code of [`application.android.ts`](https://github.com/NativeScript/nativescript-dev-webpack/blob/master/demo/AngularApp/app/application.android.ts) is bundled separately as `application.js` file which is loaded from the native `Application.java` class on launch. | ||
|
|
||
| The `application.js` bundle file is independent of the `bundle.js` and `vendor.js` files and the reason for it is that they are not loaded so early in the application launch. That's why the logic in `application.android.ts` is needed to be bundled separately in order to be loaded by the native `Application.java` as early as needed on launch. |
There was a problem hiding this comment.
- "the reason for it" would sound better as "the reason for this/that"
|
|
||
| ### Extend Android Activity | ||
|
|
||
| If your project extends android activity, it should be added to the [`appComponents`](https://github.com/NativeScript/nativescript-dev-webpack/blob/master/demo/AngularApp/webpack.config.js#L19) array by an absolute path. |
There was a problem hiding this comment.
- again "extends an Android activity"
| ]; | ||
| ``` | ||
|
|
||
| In this way and With the default config, these components [get](https://github.com/NativeScript/nativescript-dev-webpack/blob/master/demo/AngularApp/webpack.config.js#L109-L116) in the common *vendor.js* chunk and are required by the [`android-app-comopnents-loader`](https://github.com/NativeScript/nativescript-dev-webpack/blob/master/demo/AngularApp/webpack.config.js#L146-L149). |
There was a problem hiding this comment.
- not sure why "With" is capitalized
- a typo in "android-app-comopnents-loader"
sis0k0
suggested changes
Jul 16, 2018
Move custom application and activity webpack configuration information to the `extend-application-activity.md` article.
sis0k0
approved these changes
Jul 17, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the new state of the documentation article?
Add custom application and activity configuration information.
Describes NativeScript/nativescript-dev-webpack#564 (comment).