Skip to content

Commit e61e3d0

Browse files
committed
Bugfix: Making tests end_to_end/prepare_scan/* to work.
This fix was done by JD on my machine.
1 parent 5d6d314 commit e61e3d0

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

regression/end_to_end/driver.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -105,12 +105,17 @@ def run_security_driver_script(
105105
cmdline = ["python3", pipeline_driver_path]
106106
cmdline.extend(extra_commandline)
107107

108-
executable_runner = ExecutableRunner(cmdline)
109-
(stdout, stderr, ret) = executable_runner.run()
110-
if ret != 0:
111-
raise Exception(
112-
"Failed running \"%s\":\nstdout:\n\n%s\nstderr\n\n%s" % \
113-
(pretty_print_commandline(cmdline), stdout, stderr))
108+
analyzer_home = utils.get_security_analyzer_home()
109+
if analyzer_home is None:
110+
raise Exception("Set SECURITY_SCANNER_HOME to a path containing the 'security-analyzer' binary")
111+
112+
with utils.working_dir(analyzer_home):
113+
executable_runner = ExecutableRunner(cmdline)
114+
(stdout, stderr, ret) = executable_runner.run()
115+
if ret != 0:
116+
raise Exception(
117+
"Failed running \"%s\":\nstdout:\n\n%s\nstderr\n\n%s" % \
118+
(pretty_print_commandline(cmdline), stdout, stderr))
114119

115120

116121
def run_security_analyser_pipeline(
@@ -125,9 +130,6 @@ def run_security_analyser_pipeline(
125130
if extra_args is None:
126131
extra_args = []
127132

128-
analyzer_home = utils.get_security_analyzer_home()
129-
if analyzer_home is None:
130-
raise Exception("Set SECURITY_SCANNER_HOME to a path containing the 'security-analyzer' binary")
131133
absolute_binary_path = \
132134
os.path.join(base_path, relative_binary_path)
133135
absolute_rules_path = \
@@ -158,8 +160,7 @@ def run_security_analyser_pipeline(
158160
# optimisation matches:
159161
cmdline.append("--verify-csvsa-sparse-domains")
160162

161-
with utils.working_dir(analyzer_home), \
162-
utils.temp_dir_deleter(results_dir, keep_results), \
163+
with utils.temp_dir_deleter(results_dir, keep_results), \
163164
utils.temp_dir_deleter(temporary_dir, keep_results), \
164165
utils.temp_dir_deleter(common_dir, keep_results):
165166

0 commit comments

Comments
 (0)