Bugfix: when a non-last successor of instruction had a single

marek-trtik · marek-trtik · commit 5d6d314cdb89 · 2018-08-20T15:58:19.000+01:00
predecessor, then the move semantics destroyed the transformed
        state before processing the last successor.
diff --git a/src/taint-analysis/taint_summary.cpp b/src/taint-analysis/taint_summary.cpp
@@ -1653,7 +1653,7 @@ void taint_algorithm_computing_summary_of_functiont::
 
         if(dst_has_unique_predecessor)
         {
-          dst_value = std::move(*transformed);
+          dst_value = *transformed;
           work_set.insert(dst_instr_it);
         }
         else

Original file line number	Diff line number	Diff line change
`@@ -1653,7 +1653,7 @@ void taint_algorithm_computing_summary_of_functiont::`
`1653`	`1653`
`1654`	`1654`	`if(dst_has_unique_predecessor)`
`1655`	`1655`	`{`
`1656`		`- dst_value = std::move(*transformed);`
	`1656`	`+ dst_value = *transformed;`
`1657`	`1657`	`work_set.insert(dst_instr_it);`
`1658`	`1658`	`}`
`1659`	`1659`	`else`