fix($compile): move check for interpolation of on-event attributes to compile time

This makes the two interpolation errors consistent and avoids checking the same thing per link
(which previously would log the same error per link).
The test changes are not necessary but do make them stricter and more like the selmulti error tests.

Closes angular#13267

BREAKING CHANGE:

Using interpolation in any on* event attributes (e.g. `<button onclick="{{myVar}}">`) will now throw
the "nodomevents" error at compile time.
Previously the nodomevents was thrown at link time. The new behavior makes it consistent with
the "selmulti" error.
The breaking change should be rare, as it relates to incorrect API use that should not make it to
production apps in the first place.

Author: jbedard

src/ng/compile.js

@@ -2956,19 +2956,19 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
             startingTag(node));
       }
 
+      if (EVENT_HANDLER_ATTR_REGEXP.test(name)) {
+        throw $compileMinErr('nodomevents',
+            "Interpolations for HTML DOM event attributes are disallowed.  Please use the " +
+                "ng- versions (such as ng-click instead of onclick) instead.");
+      }
+
       directives.push({
         priority: 100,
         compile: function() {
             return {
               pre: function attrInterpolatePreLinkFn(scope, element, attr) {
                 var $$observers = (attr.$$observers || (attr.$$observers = createMap()));
 
-                if (EVENT_HANDLER_ATTR_REGEXP.test(name)) {
-                  throw $compileMinErr('nodomevents',
-                      "Interpolations for HTML DOM event attributes are disallowed.  Please use the " +
-                          "ng- versions (such as ng-click instead of onclick) instead.");
-                }
-
                 // If the attribute has changed since last $interpolate()ed
                 var newValue = attr[name];
                 if (newValue !== value) {

test/ng/compileSpec.js

@@ -9524,17 +9524,17 @@ describe('$compile', function() {
       // All interpolations are disallowed.
       $rootScope.onClickJs = "";
       expect(function() {
-          $compile('<button onclick="{{onClickJs}}"></script>')($rootScope);
+          $compile('<button onclick="{{onClickJs}}"></script>');
         }).toThrowMinErr(
           "$compile", "nodomevents", "Interpolations for HTML DOM event attributes are disallowed.  " +
           "Please use the ng- versions (such as ng-click instead of onclick) instead.");
       expect(function() {
-          $compile('<button ONCLICK="{{onClickJs}}"></script>')($rootScope);
+          $compile('<button ONCLICK="{{onClickJs}}"></script>');
         }).toThrowMinErr(
           "$compile", "nodomevents", "Interpolations for HTML DOM event attributes are disallowed.  " +
           "Please use the ng- versions (such as ng-click instead of onclick) instead.");
       expect(function() {
-          $compile('<button ng-attr-onclick="{{onClickJs}}"></script>')($rootScope);
+          $compile('<button ng-attr-onclick="{{onClickJs}}"></script>');
         }).toThrowMinErr(
           "$compile", "nodomevents", "Interpolations for HTML DOM event attributes are disallowed.  " +
           "Please use the ng- versions (such as ng-click instead of onclick) instead.");