Skip to content
This repository was archived by the owner on Jul 13, 2020. It is now read-only.

Byte Order Mark included in fulfilled string from SystemLoader.fetch when executed in node #388

Closed
jonoward opened this issue Jun 3, 2015 · 1 comment

Comments

@jonoward
Copy link
Contributor

jonoward commented Jun 3, 2015

When SystemLoader.fetch is executed on node, if the source file is UTF-8 and has a BOM, this is not stripped out by default (see nodejs/node-v0.x-archive#1918). This is causing an issue in systemjs-builder, when minification is enabled, and the plugin-text is used, as the BOM gets encoded, so you land up with strings like:

"\ufeff<div>hello</div>"

I'll submit a PR for this shortly

@guybedford
Copy link
Member

@jonoward thanks again for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants