added webdrivermanager of io.github.bonigarcia library interaction #73
Conversation
|
Thank you, this shows really interesting but I have to check code a bit more. Currently webdriver need is handled by Maven with https://github.com/Ardesco/selenium-standalone-server-plugin (that allows usage of local repos for stricter network access). |
|
I am using your framework for my test project and I updated and added some functions for my tests actions. |
|
If I do not use my solution I have What do you think? |
|
As said, currently I'm using self in tests (and that way instructing others) to use Maven to handle the dependencies including Webdriver (https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/blob/develop/pom.xml#L202). That of course requires that things are running with Maven and not using stand-alone jar. For latter one your solution is fine, but I have to check at code side the implementation, and if the release with new keywords related to webdriver binaries should be released still with Selenium 3 or along with Selenium 4 (alpha) release. |
| String browserName = robot.getParamsValue(args, 0, "firefox"); | ||
| String alias = robot.getParamsValue(args, 1, "None"); | ||
| String remoteUrl = robot.getParamsValue(args, 2, "None"); | ||
| String desiredCapabilities = robot.getParamsValue(args, 3, "None"); | ||
| String browserOptions = robot.getParamsValue(args, 4, "None"); | ||
| String webDriverManager = robot.getParamsValue(args, 5, "None"); | ||
|
|
||
| if (!webDriverManager.equals("None")) { |
There was a problem hiding this comment.
It would be cleaner, if Robot -class itself would take boolean as a default, and use Boolean value also here as there's no usage of String value in this case.
… for working with boolean parameters
| @@ -184,17 +186,17 @@ public void closeBrowser() { | |||
| "| `Open Browser` | http://example.com | Edge | remote_url=http://127.0.0.1:4444/wd/hub |\r\n" + | |||
| "\r\n" + | |||
| "If the provided configuration options are not enough, it is possible to use `Create Webdriver` to customize browser initialization even more.") | |||
| @ArgumentNames({ "url", "browserName=firefox", "alias=None", "remoteUrl=None", "desiredCapabilities=None", | |||
| "browserOptions=None", "webDriverManager=None" }) | |||
| @ArgumentNames({ "url", "browserName=firefox", "isWebDriverManager=false", "alias=None", "remoteUrl=None", | |||
There was a problem hiding this comment.
Changing of the order is problematic, as it could break the compatibility if place specific arguments are already used. New ones should go to end.
src/main/java/com/github/markusbernhardt/seleniumlibrary/keywords/BrowserManagement.java
Outdated
Show resolved
Hide resolved
No description provided.