This repository was archived by the owner on Feb 14, 2023. It is now read-only.
Python 3.5 for 0.22.X #49
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,13 @@ jobs: | |
| name: windows | ||
| vmImage: vs2017-win2016 | ||
| matrix: | ||
| py_3.5_32: | ||
| PYTHON_VERSION: "3.5.x" | ||
| PYTHON_ARCH: "x86" | ||
| NP_BUILD_DEP: "1.12.1" | ||
| py_3.5_64: | ||
| PYTHON_VERSION: "3.5.x" | ||
| NP_BUILD_DEP: "1.12.1" | ||
| py_3.6_32: | ||
| PYTHON_VERSION: "3.6.x" | ||
| PYTHON_ARCH: "x86" | ||
|
|
@@ -46,6 +53,11 @@ jobs: | |
| name: linux | ||
| vmImage: ubuntu-16.04 | ||
| matrix: | ||
| py_3.5_32: | ||
| MB_PYTHON_VERSION: "3.5" | ||
| PLAT: "i686" | ||
| py_3.5_64: | ||
| MB_PYTHON_VERSION: "3.5" | ||
| py_3.6_32: | ||
| MB_PYTHON_VERSION: "3.6" | ||
| PLAT: "i686" | ||
|
|
@@ -75,6 +87,9 @@ jobs: | |
| name: macOS | ||
| vmImage: xcode9-macos10.13 | ||
| matrix: | ||
| py_3.5_64: | ||
| MB_PYTHON_VERSION: "3.5" | ||
| NP_BUILD_DEP: "numpy==1.13.3" | ||
|
There was a problem hiding this comment.
We should try to use the even older numpy 1.11.0 for building as noted below. There was a problem hiding this comment. They were different for py36, I just used the same as py36 for each platform. There was a problem hiding this comment. This is also consistent with https://pypi.org/project/oldest-supported-numpy/ BTW There was a problem hiding this comment. yes for macos, but not for windows. And we don't force the version for linux. I don't know why |
||
| py_3.6_64: | ||
| MB_PYTHON_VERSION: "3.6" | ||
| NP_BUILD_DEP: "numpy==1.13.3" | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should force the build against the oldest supported of numpy for Python 3.5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but the existing ones are not following oldest supported numpy. I thought that was intentional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably because I used the version numbers for 0.23 and not 0.22.X
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway that should be fine as it is.