Skip to content
This repository was archived by the owner on May 3, 2023. It is now read-only.

Suppress some build warnings #85

Closed
wants to merge 11 commits into from
Closed

Suppress some build warnings #85

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
05caf7b
print debug
TomAugspurger May 21, 2020
8ec5122
trigger nightly build
TomAugspurger May 26, 2020
176161e
override
TomAugspurger May 26, 2020
9c63454
override
TomAugspurger May 26, 2020
aa6dc0c
sign-compare
TomAugspurger May 26, 2020
8277605
added env_vars
TomAugspurger May 26, 2020
a3f9c9e
typo
TomAugspurger May 26, 2020
219f7de
try c99
TomAugspurger May 26, 2020
320cad2
ansi C
TomAugspurger May 27, 2020
1cc7a7e
return type
TomAugspurger May 27, 2020
604e2a9
linux only
TomAugspurger May 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions azure/posix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ jobs:
vmImage: ${{ parameters.vmImage }}
variables:
REPO_DIR: "pandas"
BUILD_COMMIT: "v1.0.3"
BUILD_COMMIT: "master"
PLAT: "x86_64"
NP_BUILD_DEP: "numpy==1.13.3"
CYTHON_BUILD_DEP: "cython==0.29.16"
NIGHTLY_BUILD_COMMIT: "master"
NIGHTLY_BUILD: "false"
NIGHTLY_BUILD: "true"
TEST_DEPENDS: "pytest pytest-xdist hypothesis"
TEST_DIR: "tmp_for_test"
strategy:
Expand Down
18 changes: 18 additions & 0 deletions env_vars.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#!/usr/bin/env bash
# Environment variables for build
MACOSX_DEPLOYMENT_TARGET=10.9
# CFLAGS override for https://github.com/pandas-dev/pandas/issues/34114
CFLAGS="-std=c99 -Wno-error=maybe-uninitialized -Wno-error=sign-compare"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem with maybe-uninitialized if it gets things through, but I think sign-compare is a pretty serious issue that can easily show up for end users so not something we should ignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I don't actually know how to do that. The wheel-building repo feels like the wrong place to ensure that we're writing clean C code.

Once I get a build passing here, I'll try to add a CI job on pandas-dev/pandas that at least compiles things with the manylinux1 docker image.

# Macos's linker doesn't support stripping symbols
if [ "$(uname)" != "Darwin" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just an attempt to reduce the binary size? Feature instead of fixing an issue?

LDFLAGS="-Wl,--strip-debug"
# make sure that LDFLAGS is exposed to child processes,
# since current version of manybuild only export CFLAGS, CPPFLAGS and FFLAGS
export LDFLAGS="$LDFLAGS"
# override the default stripping flags, since we only override CFLAGS and
# the current version of manybuild pass "-strip-all" to CPPFLAGS and FFLAGS
STRIP_FLAGS=""
fi
# For verbosity: report where each command came from
export PS4='+(${BASH_SOURCE}:${LINENO}): ${FUNCNAME[0]:+${FUNCNAME[0]}(): }'
set -x