This repository was archived by the owner on May 3, 2023. It is now read-only.
Xfail more tests for python 3.10 #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @lithomas1 just restarted the nightly to confirm that these tests are just not flakey. In line with the other tests skips, we should probably have issues opened on the pandas repo and add the issue links as comments. |
|
@lithomas1 merging this so that nightlies build. can you make sure these skips are not forgotten. issue on pandas or add some comments as a follow-up |
|
Thanks @lithomas1 |
|
Ok, will do. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, more tests need xfailing on master. (Not 1.3.2 though)
This was not caught by bad luck.
In the initial PR, https://dev.azure.com/pandas-dev/pandas-wheels/_build/results?buildId=64931&view=logs&jobId=d1321064-f6c3-56b7-0172-6d994d01c836 was the build that I used to check that I was xfailing correctly for master. For some reason, that one passed, but the nightly builds are failing.
cc @simonjayhawkins