This repository was archived by the owner on Aug 30, 2024. It is now read-only.
add a date to make the dev wheels sortable #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some other changes to add so that master always gets uploaded to nightly. The relevant bit seems to be There is also a That I would like go use to suppress uploads on merges, but I doubt is works. Do we want to do that? |
Sounds good. Would you like me to add it here?
We can always just delete the uploaded artifacts. I find it helpful to be able to see what happens with uploading in a PR, which is why I have begun submitting upload-related PRs via this repo rather than my fork |
|
Lets see how this goes. Thanks Matti. |
|
The PR build got uploaded without the merge. Not convinced I like that in general. |
|
I suppose we can always delete what we don't want. |
This was referenced May 13, 2020
tylerjereddy
referenced
this pull request
in tylerjereddy/scipy-wheels
May 30, 2020
* as outlined in MacPythongh-77, downstream projects will have a hard time automatically downloading our most recently "nightly" (actually weekly) wheel uploads if we don't add a timestamp of sorts * this patch attempts to "borrow" the machinery added by Matti in `https://github.com/MacPython/numpy-wheels/pull/84` for this purpose
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref pandas-dev/pandas#33968
I didn;t notice that the wheeluploader used for rackspace modifies the wheel name so that later names will be picked up by pip before earlier ones. Since the wheels now have timetags, there should not be collisions so I also removed the
--force.