Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

strip when linking #82

Closed
wants to merge 2 commits into from
Closed

strip when linking #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5d1543
prepend to CFLAGS rather than overrid
mattip Apr 30, 2020
dcceacd
use --strip-debug
mattip May 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion env_vars.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Environment variables for build
OPENBLAS_VERSION="v0.3.7"
MACOSX_DEPLOYMENT_TARGET=10.9
CFLAGS="-std=c99 -fno-strict-aliasing"
CFLAGS="-std=c99 -fno-strict-aliasing -Wl,--strip-debug"
Copy link
Contributor

@seiko2plus seiko2plus May 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass it to the linker flags only to not break clang build, LDFLAGS="-Wl,--strip-debug"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in gh-85

4 changes: 2 additions & 2 deletions env_vars_32.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ set -x
OPENBLAS_VERSION="v0.3.7"
MACOSX_DEPLOYMENT_TARGET=10.9
# Causes failure for pre-1.19 in np.reciprocal
# CFLAGS="-msse2 -std=c99 -fno-strict-aliasing"
CFLAGS="-std=c99 -fno-strict-aliasing"
# CFLAGS="-msse2 -std=c99 -fno-strict-aliasing -Wl,--strip-debug"
CFLAGS="-std=c99 -fno-strict-aliasing -Wl,--strip-debug"